FrankChen021 commented on code in PR #20562:
URL: https://github.com/apache/druid/pull/20562#discussion_r4266064553
##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -132,6 +132,13 @@ public class QueryContexts
public static final String FORCE_PROJECTION = "forceProjections";
public static final String USE_PROJECTION = "useProjection";
+ /**
+ * Overrides the {@link org.apache.druid.segment.loading.AcquireMode} an
engine uses to acquire segments from the
+ * segment cache; see {@link QueryContext#getSegmentAcquireMode}. Intended
for testing, debugging, and performance
+ * comparison.
+ */
+ public static final String SEGMENT_ACQUIRE_MODE = "segmentAcquireMode";
Review Comment:
just a reminder, #20198 provides new API to declare a context parameter in
QueryContextParameters like this:
```java
public static final QueryContextParameter<AcquireMode>
SEGMENT_ACQUIRE_MODE =
enumParameter("segmentAcquireMode", AcquireMode.class)
.since("39.0.0").query(Query.SQL).engine(Engine.MSQ)
.description(
"""
user doc for this parameter
"""
)
.build();
```
but #20198 does not provide the API for the enum type, which is provided in
a follow up PR #20555
I will include this new parameter in a migration follow up PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
