capistrant commented on code in PR #20562:
URL: https://github.com/apache/druid/pull/20562#discussion_r4264017140
##########
processing/src/main/java/org/apache/druid/query/QueryContext.java:
##########
@@ -997,4 +998,18 @@ public RealtimeSegmentsMode getRealtimeSegmentsMode()
}
return QueryContexts.DEFAULT_REALTIME_SEGMENTS_MODE;
}
+
+ /**
+ * Returns the {@link AcquireMode} set by {@link
QueryContexts#SEGMENT_ACQUIRE_MODE}, or {@code defaultValue} (the
+ * engine's own choice) if absent. Currently only honored by MSQ leaf stage
processors.
+ * <p>
+ * {@link AcquireMode#PARTIAL} degrades to {@link AcquireMode#FULL} where
partial downloads are unavailable, such as
+ * when they are disabled by configuration or the segment is not
range-readable. Forcing {@link AcquireMode#PARTIAL}
+ * where the engine defaults to {@link AcquireMode#FULL} fails at cursor
creation if the engine reads segments through
+ * the synchronous cursor API.
Review Comment:
does this fail in a descriptive way where it is obvious that the context key
use is unsupported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
