clintropolis commented on code in PR #20562:
URL: https://github.com/apache/druid/pull/20562#discussion_r4266533095
##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -132,6 +132,13 @@ public class QueryContexts
public static final String FORCE_PROJECTION = "forceProjections";
public static final String USE_PROJECTION = "useProjection";
+ /**
+ * Overrides the {@link org.apache.druid.segment.loading.AcquireMode} an
engine uses to acquire segments from the
+ * segment cache; see {@link QueryContext#getSegmentAcquireMode}. Intended
for testing, debugging, and performance
+ * comparison.
+ */
+ public static final String SEGMENT_ACQUIRE_MODE = "segmentAcquireMode";
Review Comment:
as mentioned in
https://github.com/apache/druid/pull/20562#discussion_r4265054004, I do not
currently wish to document this parameter for users since it is mainly intended
for devs for internal testing. There are quite a few query context parameters
like this (used for testing and comparison to assist devs without ever really
intended to be used by users), as long as there is a way to flag them so they
don't show up in the docs and such (or can be split off to a separate 'do not
use these unless you really really know what you are doing' section) then I
suppose I have no complaints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
