freemandealer commented on code in PR #14014:
URL: https://github.com/apache/doris/pull/14014#discussion_r1016109728
##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -37,7 +37,8 @@ BinaryDictPageBuilder::BinaryDictPageBuilder(const
PageBuilderOptions& options)
// TODO: the data page builder type can be created by Factory according to
user config
_data_page_builder.reset(new
BitshufflePageBuilder<OLAP_FIELD_TYPE_INT>(options));
PageBuilderOptions dict_builder_options;
- dict_builder_options.data_page_size = _options.dict_page_size;
+ dict_builder_options.data_page_size = _options.data_page_size;
Review Comment:
> > std::min(datapagesize:dict page size)? If user set data page size larger
than dict page size??
>
> in this case, we still need to use dict_page_size, see `is_page_full()`,
for a dict page, we use dict_page_size to judge if it's full.
instead, we should always use the smaller one when init. dict_page_size is
only used for judging is_page_full.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
