zhannngchen commented on code in PR #14014:
URL: https://github.com/apache/doris/pull/14014#discussion_r1015267691
##########
be/src/olap/rowset/segment_v2/binary_plain_page.h:
##########
@@ -53,8 +53,14 @@ class BinaryPlainPageBuilder : public PageBuilder {
}
bool is_page_full() override {
- // data_page_size is 0, do not limit the page size
- return _options.data_page_size != 0 && _size_estimate >
_options.data_page_size;
+ bool ret;
+ if (_options.is_dict_page) {
+ // data_page_size is 0, do not limit the page size
+ ret = _options.data_page_size != 0 && _size_estimate >
_options.dict_page_size;
Review Comment:
should be `_options.dict_page_size != 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
