freemandealer commented on code in PR #14014: URL: https://github.com/apache/doris/pull/14014#discussion_r1016086181
########## be/src/olap/rowset/segment_v2/binary_dict_page.cpp: ########## @@ -37,7 +37,8 @@ BinaryDictPageBuilder::BinaryDictPageBuilder(const PageBuilderOptions& options) // TODO: the data page builder type can be created by Factory according to user config _data_page_builder.reset(new BitshufflePageBuilder<OLAP_FIELD_TYPE_INT>(options)); PageBuilderOptions dict_builder_options; - dict_builder_options.data_page_size = _options.dict_page_size; + dict_builder_options.data_page_size = _options.data_page_size; Review Comment: sure, will do just in case, though I do not know in which case will a user do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org