zhannngchen commented on code in PR #14014:
URL: https://github.com/apache/doris/pull/14014#discussion_r1015120327
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -274,6 +274,7 @@ Status ScalarColumnWriter::init() {
// create page builder
PageBuilderOptions opts;
opts.data_page_size = _opts.data_page_size;
+ opts.dict_page_size = _opts.data_page_size; // init smaller dict page,
grow if need more
Review Comment:
We can leave `dict_page_size` as 1M, and not to change the `data_page_size`
when we initialize the `_dict_builder`. So you can reserve the faststring with
`min(data_page_size, dict_page_size)` and use `dict_page_size` to check if the
page is full.
##########
be/src/olap/rowset/segment_v2/binary_plain_page.h:
##########
@@ -158,6 +166,7 @@ class BinaryPlainPageBuilder : public PageBuilder {
uint32_t _last_value_size = 0;
faststring _first_value;
faststring _last_value;
+ bool _is_dict_page;
Review Comment:
move it to `PageBuilderOptions` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
