yiguolei commented on code in PR #33339:
URL: https://github.com/apache/doris/pull/33339#discussion_r1555196786
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -634,7 +636,11 @@ public void exec() throws Exception {
if
(!queueToken.waitSignal(this.queryOptions.getExecutionTimeout() * 1000)) {
LOG.error("query (id=" + DebugUtil.printId(queryId) +
") " + queueToken.getOfferResultDetail());
queryQueue.returnToken(queueToken);
- throw new
UserException(queueToken.getOfferResultDetail());
+ if (queueToken.isCancelled()) {
+ throw new
RuntimeException(queueToken.getOfferResultDetail());
Review Comment:
client1 --->(stmt executor thread ) select * --> plan ---> coord --->queue
--> send fragment
ctrl + C kill query
client 2 ---> kill connection id ---> kill query
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -634,7 +636,11 @@ public void exec() throws Exception {
if
(!queueToken.waitSignal(this.queryOptions.getExecutionTimeout() * 1000)) {
LOG.error("query (id=" + DebugUtil.printId(queryId) +
") " + queueToken.getOfferResultDetail());
queryQueue.returnToken(queueToken);
- throw new
UserException(queueToken.getOfferResultDetail());
+ if (queueToken.isCancelled()) {
+ throw new
RuntimeException(queueToken.getOfferResultDetail());
Review Comment:
client1 --->(stmt executor thread ) select * --> plan ---> coord --->queue
--> send fragment
ctrl + C kill query
client 2 ---> kill connection id ---> kill query
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -623,7 +623,9 @@ public void exec() throws Exception {
if (context != null) {
if (Config.enable_workload_group) {
this.setTWorkloadGroups(context.getEnv().getWorkloadGroupMgr().getWorkloadGroup(context));
- if (Config.enable_query_queue &&
!context.getSessionVariable().getBypassWorkloadGroup()) {
+ boolean shouldQueue = Config.enable_query_queue &&
!context.getSessionVariable()
Review Comment:
sleep 1000000
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -623,7 +623,9 @@ public void exec() throws Exception {
if (context != null) {
if (Config.enable_workload_group) {
this.setTWorkloadGroups(context.getEnv().getWorkloadGroupMgr().getWorkloadGroup(context));
- if (Config.enable_query_queue &&
!context.getSessionVariable().getBypassWorkloadGroup()) {
+ boolean shouldQueue = Config.enable_query_queue &&
!context.getSessionVariable()
Review Comment:
sleep 1000000
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1438,6 +1444,7 @@ public boolean shouldCancel(List<Backend>
currentBackends) {
// if any, as well as all plan fragments on remote nodes.
public void cancel() {
cancel(Types.PPlanFragmentCancelReason.USER_CANCEL);
Review Comment:
sleep 1000000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
