yiguolei commented on code in PR #33339:
URL: https://github.com/apache/doris/pull/33339#discussion_r1555132616
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1438,6 +1444,7 @@ public boolean shouldCancel(List<Backend>
currentBackends) {
// if any, as well as all plan fragments on remote nodes.
public void cancel() {
cancel(Types.PPlanFragmentCancelReason.USER_CANCEL);
+ queueToken.signalForCancel();
Review Comment:
cancel 方法应当加到queryqueue 中 cancel(QueueToken token)，在这个方法中需要：
1. 把token 从queue 中移除
2. 标记为cancel 状态
3. 发送signal
否则这个query token 被cancel了，但是实际他还会占用着queue的资源，新的query 无法排队。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
