yiguolei commented on code in PR #33339: URL: https://github.com/apache/doris/pull/33339#discussion_r1554981561
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueueToken.java: ########## @@ -38,7 +38,8 @@ public int compareTo(QueueToken other) { public enum TokenState { ENQUEUE_SUCCESS, - READY_TO_RUN Review Comment: 感觉不用给token 加cancel 状态,因为排队之后,拿出来执行,也是cancel的状态,就自动不执行了啊。 我觉得我们应该给statement executor和coordinator 都检查一下cancel 状态,遇到cancel状态的直接扔exception 就可以了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org