yiguolei commented on code in PR #33339:
URL: https://github.com/apache/doris/pull/33339#discussion_r1555134165


##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueueToken.java:
##########
@@ -38,7 +38,8 @@ public int compareTo(QueueToken other) {
 
     public enum TokenState {
         ENQUEUE_SUCCESS,
-        READY_TO_RUN
+        READY_TO_RUN,
+        CANCELLED_IN_QUEUE

Review Comment:
   不过我觉得,最好单独加一个 isCancelled 标记位,别改这个TokenState,我记得这个有坑。
   另外,外部也不用这个cancelled 标记位,都是内部的方法在调用,所以我感觉也可控。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to