yiguolei commented on code in PR #29591:
URL: https://github.com/apache/doris/pull/29591#discussion_r1442603473
##########
be/src/runtime/fragment_mgr.h:
##########
@@ -152,6 +152,11 @@ class FragmentMgr : public RestMonitorIface {
return _query_ctx_map.size();
}
+ std::unordered_map<TUniqueId, std::shared_ptr<QueryContext>>&
get_query_ctx_map() {
Review Comment:
never return this map, because you add lock to return a reference,the map
maybe modified concurrently.
I think you could add a method named colloect_query_statistics in
FragmentMgr to avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
