wangbo commented on code in PR #29591:
URL: https://github.com/apache/doris/pull/29591#discussion_r1442611854


##########
be/src/exec/exec_node.cpp:
##########
@@ -276,6 +260,10 @@ Status ExecNode::create_tree_helper(RuntimeState* state, 
ObjectPool* pool,
     // Step 1 Create current ExecNode according to current thrift plan node.
     ExecNode* cur_exec_node = nullptr;
     RETURN_IF_ERROR(create_node(state, pool, cur_plan_node, descs, 
&cur_exec_node));
+    if (cur_exec_node != nullptr) {
+        state->get_query_ctx()->register_query_statistics(
+                cur_exec_node->get_query_stats_shared_ptr());

Review Comment:
   你是说命名还是不能用sharedptr,querystatistic的生命周期必须是要比query长的啊,所以只能用sharedptr存



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to