yiguolei commented on code in PR #29591:
URL: https://github.com/apache/doris/pull/29591#discussion_r1442607425


##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java:
##########
@@ -168,6 +168,14 @@ protected void auditAfterExec(String origStmt, 
StatementBase parsedStmt,
         AuditLogHelper.logAuditLog(ctx, origStmt, parsedStmt, statistics, 
printFuzzyVariables);
     }
 
+    protected void asyncAuditAfterExec(String origStmt, StatementBase 
parsedStmt,

Review Comment:
   not add this method.
   There should be only one auditlog log exec method. Not use sync or async to 
distinguish them. It is very confused.
   For example, when to use sync when to use async???



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to