eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405591908
##########
be/src/olap/rowset/segment_creator.h:
##########
@@ -142,7 +145,7 @@ class SegmentFlusher {
int64_t* flush_size = nullptr);
private:
- RowsetWriterContext _context;
+ RowsetWriterContext* _context;
Review Comment:
since some variables has no copy constructor, like `std::mutex`
##########
be/src/olap/memtable.cpp:
##########
@@ -505,4 +505,4 @@ std::unique_ptr<vectorized::Block> MemTable::to_block() {
return vectorized::Block::create_unique(_output_mutable_block.to_block());
}
-} // namespace doris
+} // namespace doris
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
