eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405575877
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -436,8 +436,7 @@ ColumnPtr ColumnObject::index(const IColumn& indexes,
size_t limit) const {
}
bool ColumnObject::Subcolumn::check_if_sparse_column(size_t num_rows) {
- constexpr static size_t s_threshold_rows_estimate_sparse_column = 1000;
- if (num_rows < s_threshold_rows_estimate_sparse_column) {
+ if (num_rows < config::variant_threshold_rows_to_estimate_sparse_column) {
Review Comment:
only sparse column will be affected， others will not
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -436,8 +436,7 @@ ColumnPtr ColumnObject::index(const IColumn& indexes,
size_t limit) const {
}
bool ColumnObject::Subcolumn::check_if_sparse_column(size_t num_rows) {
- constexpr static size_t s_threshold_rows_estimate_sparse_column = 1000;
- if (num_rows < s_threshold_rows_estimate_sparse_column) {
+ if (num_rows < config::variant_threshold_rows_to_estimate_sparse_column) {
Review Comment:
only sparse column will be affected， others will not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
