eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405574707
##########
be/src/olap/match_predicate.cpp:
##########
@@ -39,34 +44,37 @@ PredicateType MatchPredicate::type() const {
return PredicateType::MATCH;
}
-Status MatchPredicate::evaluate(const Schema& schema, InvertedIndexIterator*
iterator,
- uint32_t num_rows, roaring::Roaring* bitmap)
const {
+Status MatchPredicate::evaluate(const vectorized::NameAndTypePair&
name_with_type,
+ InvertedIndexIterator* iterator, uint32_t
num_rows,
+ roaring::Roaring* bitmap) const {
if (iterator == nullptr) {
return Status::OK();
}
if (_skip_evaluate(iterator)) {
return Status::Error<ErrorCode::INVERTED_INDEX_EVALUATE_SKIPPED>(
"match predicate evaluate skipped.");
}
- auto column_desc = schema.column(_column_id);
+ auto type = name_with_type.second;
+ const std::string& name = name_with_type.first;
roaring::Roaring roaring;
auto inverted_index_query_type =
_to_inverted_index_query_type(_match_type);
-
- if (is_string_type(column_desc->type()) ||
- (column_desc->type() == FieldType::OLAP_FIELD_TYPE_ARRAY &&
- is_string_type(column_desc->get_sub_field(0)->type_info()->type()))) {
+ TypeDescriptor column_desc = type->get_type_as_type_descriptor();
+ if (is_string_type(column_desc.type)) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
