eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405587875
##########
be/src/olap/rowset/segment_v2/inverted_index_desc.cpp:
##########
@@ -27,30 +27,32 @@ const std::string segment_suffix = ".dat";
const std::string index_suffix = ".idx";
const std::string index_name_separator = "_";
-std::string InvertedIndexDescriptor::get_temporary_index_path(const
std::string& segment_path,
- uint32_t uuid) {
+std::string InvertedIndexDescriptor::get_temporary_index_path(
+ const std::string& segment_path, uint32_t uuid, const std::string&
index_suffix_path) {
return StripSuffixString(segment_path, segment_suffix) +
index_name_separator +
- std::to_string(uuid);
+ std::to_string(uuid) + index_suffix_path;
}
std::string InvertedIndexDescriptor::get_index_file_name(const std::string&
segment_path,
- uint32_t uuid) {
+ uint32_t uuid,
+ const std::string&
index_suffix_path) {
return StripSuffixString(segment_path, segment_suffix) +
index_name_separator +
- std::to_string(uuid) + index_suffix;
+ std::to_string(uuid) + index_suffix_path + index_suffix;
Review Comment:
i don't think it's safe to add `_` since some logic rely on the format to
parse tablet_id, index_id, ...etc. So i would rather use anthother speator like
`$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
