xinyiZzz commented on code in PR #21755:
URL: https://github.com/apache/doris/pull/21755#discussion_r1264306437
##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -173,7 +174,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size) {
}
// Large memory alloc should use allocator.h
// Direct malloc or new large memory, unable to catch std::bad_alloc, BE
may OOM.
- if (size > 1024l * 1024 * 1024 && !doris::config::disable_memory_gc) { //
1G
+ if (size > 1024l * 1024 * 1024 && !doris::config::disable_memory_gc &&
!in_allocator) { // 1G
Review Comment:
同上，放到thread context应该没问题
##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -173,7 +174,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size) {
}
// Large memory alloc should use allocator.h
// Direct malloc or new large memory, unable to catch std::bad_alloc, BE
may OOM.
- if (size > 1024l * 1024 * 1024 && !doris::config::disable_memory_gc) { //
1G
+ if (size > 1024l * 1024 * 1024 && !doris::config::disable_memory_gc &&
!in_allocator) { // 1G
Review Comment:
同上，放到thread context应该没问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
