yiguolei commented on code in PR #21755: URL: https://github.com/apache/doris/pull/21755#discussion_r1264265045
########## be/src/util/mem_info.cpp: ########## @@ -60,14 +60,14 @@ std::string MemInfo::_s_mem_limit_str = ""; int64_t MemInfo::_s_soft_mem_limit = -1; std::string MemInfo::_s_soft_mem_limit_str = ""; -int64_t MemInfo::_s_allocator_cache_mem = 0; +std::atomic<int64_t> MemInfo::_s_allocator_cache_mem = 0; Review Comment: 不要带这些代码，我们这次的pr 只保留stacktrace的，这样我们才能往1.2-lts pick，太多别的代码，就不敢pick了。 ########## be/src/util/mem_info.cpp: ########## @@ -60,14 +60,14 @@ std::string MemInfo::_s_mem_limit_str = ""; int64_t MemInfo::_s_soft_mem_limit = -1; std::string MemInfo::_s_soft_mem_limit_str = ""; -int64_t MemInfo::_s_allocator_cache_mem = 0; +std::atomic<int64_t> MemInfo::_s_allocator_cache_mem = 0; Review Comment: 不要带这些代码，我们这次的pr 只保留stacktrace的，这样我们才能往1.2-lts pick，太多别的代码，就不敢pick了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
