yiguolei commented on code in PR #21755:
URL: https://github.com/apache/doris/pull/21755#discussion_r1264747413


##########
be/src/common/status.h:
##########
@@ -361,7 +363,7 @@ class Status {
 #ifdef ENABLE_STACKTRACE
         if (stacktrace && capture_stacktrace(code)) {
             status._err_msg->_stack = get_stack_trace();
-            LOG(WARNING) << "meet error status: " << status;
+            // LOG(WARNING) << "meet error status: " << status; // print only 
where needed, may print too many stacks.

Review Comment:
   这个不要删,这个是因为我们status 可能返回了,不打印,所以xl 加的。



##########
be/src/common/status.h:
##########
@@ -361,7 +363,7 @@ class Status {
 #ifdef ENABLE_STACKTRACE
         if (stacktrace && capture_stacktrace(code)) {
             status._err_msg->_stack = get_stack_trace();
-            LOG(WARNING) << "meet error status: " << status;
+            // LOG(WARNING) << "meet error status: " << status; // print only 
where needed, may print too many stacks.

Review Comment:
   这个不要删,这个是因为我们status 可能返回了,不打印,所以xl 加的。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to