yiguolei commented on code in PR #21755:
URL: https://github.com/apache/doris/pull/21755#discussion_r1264265188
##########
be/src/io/fs/local_file_reader.h:
##########
@@ -49,6 +49,8 @@ class LocalFileReader final : public FileReader {
FileSystemSPtr fs() const override { return _fs; }
+ void* read_at_by_mmap();
Review Comment:
我不确定1.2 是否有local file reader 这个代码，如果pick 到1.2 可能不好搞。
如果有可能的话，我觉得我们直接用std::filesystem 来读取文件吧
##########
be/src/io/fs/local_file_reader.h:
##########
@@ -49,6 +49,8 @@ class LocalFileReader final : public FileReader {
FileSystemSPtr fs() const override { return _fs; }
+ void* read_at_by_mmap();
Review Comment:
我不确定1.2 是否有local file reader 这个代码，如果pick 到1.2 可能不好搞。
如果有可能的话，我觉得我们直接用std::filesystem 来读取文件吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
