imay commented on a change in pull request #2573: implements create drop show index syntax for bitmap index [#2487] URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r362231564
########## File path: fe/src/main/cup/sql_parser.cup ########## @@ -1711,6 +1759,13 @@ column_definition ::= :} ; +index_definition ::= + KW_INDEX ident:indexName opt_index_type:indexType LPAREN ident_list:cols RPAREN opt_comment:comment Review comment: I think its better to move index_type after ident_list ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org