imay commented on a change in pull request #2573: implements create drop show
index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r362321613
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -1438,4 +1457,19 @@ public void cancel(CancelStmt stmt) throws DdlException
{
jobDone(schemaChangeJob);
}
}
+
+ private void processAddIndex(CreateIndexClause alterClause, List<Index>
indexes) {
+ if (alterClause.getIndex() != null) {
+ indexes.add(alterClause.getIndex());
+ }
+ }
+
+ private void processDropIndex(DropIndexClause alterClause, List<Index>
indexes) {
+ for (Index idx : indexes) {
Review comment:
This is not a good idea to iterate list in this way when element will be
deleted in the loop block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
