imay commented on a change in pull request #2573: implements create drop show 
index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r361904848
 
 

 ##########
 File path: be/src/olap/olap_snapshot_converter.cpp
 ##########
 @@ -326,6 +326,9 @@ OLAPStatus OlapSnapshotConverter::to_column_pb(const 
ColumnMessage& column_msg,
     if (column_msg.has_is_bf_column()) {
         column_pb->set_is_bf_column(column_msg.is_bf_column());
     }
+    if (column_msg.has_is_bitmap_column()) {
 
 Review comment:
   better rename it to is_bitmap_index()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to