imay commented on a change in pull request #2573: implements create drop show
index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r361905955
##########
File path: fe/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
##########
@@ -362,6 +392,68 @@ public void analyze(Analyzer analyzer) throws
AnalysisException, UserException {
}
columns.add(col);
}
+
+ if (CollectionUtils.isNotEmpty(indexDefs)) {
+ Set<String> distinct = new
TreeSet<>(String.CASE_INSENSITIVE_ORDER);
+ Set<List<String>> distinctCol = new HashSet<>();
+
+ for (IndexDef indexDef : indexDefs) {
+ indexDef.analyze();
+ if (engineName.equalsIgnoreCase("olap")) {
Review comment:
```suggestion
if (!engineName.equalsIgnoreCase("olap")) {
throw new Exception;
}
```
which can make code less indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
