allthingssecurity commented on PR #27689:
URL: https://github.com/apache/camel/pull/27689#issuecomment-6120118988
Pushed ee2a700436af on top (no force-push).
1. `Iterable`: fixed, see the inline reply. Only a `Collection` or an
`Object[]` is split; a `JsonObject`, a
`JsonArray` and a `Map` are one header as on main, with a test each.
2. Shared helper: added `HttpUtil.applyHeaderValue(strategy, exchange,
value, tc, key, consumer)` in camel-support,
next to `applyHeader` (which it calls for the elements). It is a new
public static method; no existing signature
changes. `HttpUtilTest` has 10 new tests for it. #27690 adds the same
method and the same tests byte for byte, so
the two PRs do not depend on each other: `git merge-tree` of the two
heads (ee2a700436af, c7ec6a285855), and of
each head on a squash of the other onto main, is clean and gives one copy
of the method. I did not move
`VertxPlatformHttpSupport` to the helper: it iterates every value
(VertxPlatformHttpSupport.java:144,
`createIterator(value, null, true)`, so also a `byte[]` and a `Map`), and
the helper would change that. That
is a separate decision.
3. Upgrade guide: the sentence comparing with camel-http is removed, and the
other comparisons with it. The note now
says what changes, what stays (String, `byte[]`, `Map`, `JsonObject`,
`JsonArray`) and how to get the old
single header. The PR description is rewritten for the final behaviour
and has no camel-http claim; it is the text
for the squash commit. The message of the first commit is unchanged (no
force-push).
Tests: camel-vertx-http 107, 0 failures, 1 skipped (as on main);
camel-support 136, 0 failures.
Convention: with this change both PRs do the same thing through the same
helper, one header per value for a
`Collection` or `Object[]` and one header for anything else.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
