allthingssecurity commented on PR #27689: URL: https://github.com/apache/camel/pull/27689#issuecomment-6115894261
A correction to what I wrote in this PR. The description, the upgrade guide note, the test javadoc and the first commit message said that the fix sends one HTTP header per value "as camel-http, camel-netty-http and camel-undertow do". That is wrong for camel-http: `HttpProducer.applyHeader` sends two or more values as one header in the form `[a, b]`, on purpose (its comment says so), and only a single value as is. camel-netty-http (`DefaultNettyHttpBinding.toNettyRequest`) and camel-undertow (`DefaultUndertowHttpBinding.toHttpRequest`) do send one header per value. So the HTTP producers are not uniform, and this PR aligns camel-vertx-http with netty-http and undertow, not with camel-http. daec4bac0ad0 corrects the wording of the upgrade guide note and the test javadoc (no code change; 104 tests, 0 failures, 1 skipped), and the description now has a correction paragraph at the top. The message of the first commit still has the wrong sentence; I did not rewrite history, please ignore it or fix it when squashing. What stays true: on main a `String[]` header is sent as `[Ljava.lang.String;@...` and an empty List as `[]`, and camel-vertx-http does not send a List header the way netty-http and undertow do. Which convention do you want for camel-vertx-http? If the `[a, b]` form of camel-http is the intended one for HTTP producers (CAMEL-4212 introduced it, and CAMEL-11662 asked to change it for camel-ahc and was closed as Won't Fix), this PR should be closed, or reduced to the array and empty-collection cases. If one header per value is preferred, the PR can stay as it is. I am fine with either. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
