gnodet commented on PR #27430: URL: https://github.com/apache/camel/pull/27430#issuecomment-6049954788
All review items from the latest round have been addressed: - **Tests strengthened**: `testLocalConfigurationBeforeConsumerFiringCount` now uses an `AtomicInteger` counter asserted to 1 (not `constant(1)`), and also validates the deferral: a header set by the consumer *after* the sub-route call is visible to the BeforeConsumer onCompletion. - **`testGlobalStarConfiguration`** now includes a two-hop exchange (`direct:start3` → `direct:sub`) asserting `mock:global` fires exactly once, confirming `*` is treated as global (not route-scoped). - **`testOnCompleteOnlyAndOnFailureOnlyInSameNamedConfig`**: migrated to `assertThrows`. - **Constant renamed**: `ON_COMPLETION_FIRED_CONFIG_IDS` → `ON_COMPLETION_FIRED_IDS` with updated Javadoc. - **BeforeConsumer map allocation**: guarded with `!afterConsumer` to keep the AfterConsumer hot path clean. - **YAML/XML parity follow-up**: filed as [CAMEL-25420](https://issues.apache.org/jira/browse/CAMEL-25420). CI build on JDK 17 hit the 6h timeout (infra issue, not a code failure) and has been re-triggered. JDK 25 build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
