gnodet-bot commented on code in PR #27430:
URL: https://github.com/apache/camel/pull/27430#discussion_r4206558380
##########
core/camel-core-model/src/main/java/org/apache/camel/model/RouteConfigurationDefinition.java:
##########
@@ -233,8 +233,18 @@ public final OnExceptionDefinition onException(Class<?
extends Throwable>... exc
public OnCompletionDefinition onCompletion() {
OnCompletionDefinition answer = new OnCompletionDefinition();
answer.setRouteConfiguration(this);
Review Comment:
⚠️ **Pre-existing gap:** YAML/XML route-configuration `onCompletion`
definitions bypass this fluent method entirely (they call `setOnCompletions()`
directly via the deserializer). As a result, they never receive the
`routeConfiguration` back-reference set here, and the new conditional
`routeScoped` logic doesn't apply to them — the configurationId-based dedup in
`OnCompletionProcessor` won't fire for YAML/XML-defined route configurations.
Consider addressing in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
