pierrejeambrun commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2213253937
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -51,7 +57,7 @@ const DeleteDagButton = ({ dagDisplayName, dagId, withText =
true }: DeleteDagBu
icon={<FiTrash2 />}
onClick={onOpen}
text={translate("dagActions.delete.button")}
- variant="solid"
+ variant={variant}
Review Comment:
Oh that's because we specify the variant. I wouldn't do that, I think all
headers buttons should behave the same (with text, and without text).
(outlined when `withText=True` and `ghost` in minimized format)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
