Jasperora commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2215107092
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -51,7 +57,7 @@ const DeleteDagButton = ({ dagDisplayName, dagId, withText =
true }: DeleteDagBu
icon={<FiTrash2 />}
onClick={onOpen}
text={translate("dagActions.delete.button")}
- variant="solid"
+ variant={variant}
Review Comment:
Hi @pierrejeambrun. Thanks for your suggestion. I've fixed the css part.
Demo is at [#53064
(comment)](https://github.com/apache/airflow/pull/53064#discussion_r2215083872).
My final solution uses a div with style `width="100%"` to wrap buttons and
pass `width="100%"` to each of the button. I've tried that it doesn't work if
we remove any one of them.
For `DeleteDagButton.tsx`, I deconstruct `width` from `...rest` since
passing the whole `...rest` to `ActionButton` would cause a TypeScript type
error.
Please let me know if you have further suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
