Jasperora commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2212073733
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -51,7 +57,7 @@ const DeleteDagButton = ({ dagDisplayName, dagId, withText =
true }: DeleteDagBu
icon={<FiTrash2 />}
onClick={onOpen}
text={translate("dagActions.delete.button")}
- variant="solid"
+ variant={variant}
Review Comment:
Hi @pierrejeambrun, thanks for pointing out. I didn't notice it. I checked
the definition of `ActionButton` ([Line
57](https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/ui/src/components/ui/ActionButton.tsx#L57C11-L57C49)).
When `withText` is True, variant would depend on the value passed to it.
(defaults to `outline`)
Thus, if we want variant to be `outline`, we don't need this part.
However, I noticed that maybe letting the button be `ghost` is better for
the problem mentioned in [#53064
(comment)](https://github.com/apache/airflow/pull/53064#discussion_r2196760920).
Otherwise, we might need to use a regular button for delete dag here like
@bbovenzi mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
