Jasperora commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2212072807
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -77,6 +78,9 @@ export const DetailsLayout = ({ children, error, isLoading,
tabs }: Props) => {
<Flex gap={1}>
<SearchDagsButton />
{dag === undefined ? undefined : <TriggerDAGButton dag={dag} />}
+ {dag === undefined ? undefined : (
+ <DeleteDagButton dagDisplayName={dag.dag_display_name}
dagId={dag.dag_id} />
+ )}
Review Comment:
Hi @bbovenzi, thanks for your suggestion. Do you think making this button
`ghost` instead of `outline` is enough to solve this problem?
In my opinion, using a regular button here is totally feasible but needs an
additional file created in
`airflow-core/src/airflow/ui/src/components/DagActions`. And this file is
nearly the same as `DeleteDagButton.tsx`, which might seem a little bit
redundant and confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
