jscheffl commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2195734781
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -77,6 +78,9 @@ export const DetailsLayout = ({ children, error, isLoading,
tabs }: Props) => {
<Flex gap={1}>
<SearchDagsButton />
{dag === undefined ? undefined : <TriggerDAGButton dag={dag} />}
+ {dag === undefined ? undefined : (
+ <DeleteDagButton dagDisplayName={dag.dag_display_name}
dagId={dag.dag_id} />
+ )}
Review Comment:
Actually I see this similar to be a "not common" usage like "Reparse Dag".
Can we maybe make a small dropdown menu with the name "Admin" or "Advanced" and
have "Reparse Dag" and "Delete Dag" as the menu actions?
I very much fear too many options and the "Delete Dag" button in very
obvious is so destructive of all history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
