steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land.
In D131067#3705783 <https://reviews.llvm.org/D131067#3705783>, @t-8ch wrote: > In D131067#3702044 <https://reviews.llvm.org/D131067#3702044>, @steakhal > wrote: > >> Please, consider stating the motivation behind this change. > > This is now added. I was about the empty revision summary. Generally, we use that to highlight the motivation of some proposed change. We also tend to keep it in sync which the commit message. (I think arcanist auto updates the review version of the summary to match with the actual message once you commit your change.) Sorry for blocking this change. It makes sense now. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:537 + CallExpr::const_arg_range Args) { + for (const auto It : llvm::zip(FD->parameters(), Args)) { + if (!std::get<0>(It)->getType()->isReferenceType()) ---------------- I think as we are on C++17 now, we could use structured bindings. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
