martong added a comment. Thanks, looks good with some nits.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:556-558 + unsigned numParams = FD->getNumParams(); + for (unsigned i = 0; i < numParams; ++i) { + findReferenceParameter(FD->getParamDecl(i), CE->getArg(i)); ---------------- This could be hoisted into `findCallReferenceParameters(const FunctionDecl *FD)` thus avoiding code repetition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits