t-8ch updated this revision to Diff 450717.
t-8ch marked 5 inline comments as done.
t-8ch added a comment.
Implement stylistic change requested by reviewers and add better description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131067/new/
https://reviews.llvm.org/D131067
Files:
clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
clang/test/Analysis/dead-stores.cpp
Index: clang/test/Analysis/dead-stores.cpp
===================================================================
--- clang/test/Analysis/dead-stores.cpp
+++ clang/test/Analysis/dead-stores.cpp
@@ -217,3 +217,22 @@
return i + j;
}
+//===----------------------------------------------------------------------===//
+// Dead store checking involving references.
+//===----------------------------------------------------------------------===//
+
+void functionReferenceParameter(int &i) {}
+
+struct constructorReferenceParameter {
+ constructorReferenceParameter(int &i) {}
+};
+
+void referenceParameters() {
+ int i = 5;
+ functionReferenceParameter(i);
+ i = 6;
+
+ int j = 7;
+ constructorReferenceParameter k(j);
+ j = 8;
+}
Index: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
+++ clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
@@ -483,12 +483,21 @@
void operator()(const Stmt *S) {
// Check for '&'. Any VarDecl whose address has been taken we treat as
// escaped.
- // FIXME: What about references?
if (auto *LE = dyn_cast<LambdaExpr>(S)) {
findLambdaReferenceCaptures(LE);
return;
}
+ if (auto *CE = dyn_cast<CallExpr>(S)) {
+ findCallReferenceParameters(CE);
+ return;
+ }
+
+ if (auto *CE = dyn_cast<CXXConstructExpr>(S)) {
+ findConstructorReferenceParameters(CE);
+ return;
+ }
+
const UnaryOperator *U = dyn_cast<UnaryOperator>(S);
if (!U)
return;
@@ -522,6 +531,31 @@
Escaped.insert(VD);
}
}
+
+ void findReferenceParameter(const FunctionDecl *FD,
+ CallExpr::const_arg_range Args) {
+ for (const auto It : llvm::zip(FD->parameters(), Args)) {
+ if (!std::get<0>(It)->getType()->isReferenceType())
+ continue;
+
+ auto *DRE = dyn_cast<DeclRefExpr>(std::get<1>(It));
+ if (!DRE)
+ continue;
+
+ if (auto *VD = dyn_cast<VarDecl>(DRE->getDecl()))
+ Escaped.insert(VD);
+ }
+ }
+
+ void findCallReferenceParameters(const CallExpr *CE) {
+ if (auto *FD = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl())) {
+ findReferenceParameter(FD, CE->arguments());
+ }
+ }
+
+ void findConstructorReferenceParameters(const CXXConstructExpr *CE) {
+ findReferenceParameter(CE->getConstructor(), CE->arguments());
+ }
};
} // end anonymous namespace
Index: clang/test/Analysis/dead-stores.cpp
===================================================================
--- clang/test/Analysis/dead-stores.cpp
+++ clang/test/Analysis/dead-stores.cpp
@@ -217,3 +217,22 @@
return i + j;
}
+//===----------------------------------------------------------------------===//
+// Dead store checking involving references.
+//===----------------------------------------------------------------------===//
+
+void functionReferenceParameter(int &i) {}
+
+struct constructorReferenceParameter {
+ constructorReferenceParameter(int &i) {}
+};
+
+void referenceParameters() {
+ int i = 5;
+ functionReferenceParameter(i);
+ i = 6;
+
+ int j = 7;
+ constructorReferenceParameter k(j);
+ j = 8;
+}
Index: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
+++ clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
@@ -483,12 +483,21 @@
void operator()(const Stmt *S) {
// Check for '&'. Any VarDecl whose address has been taken we treat as
// escaped.
- // FIXME: What about references?
if (auto *LE = dyn_cast<LambdaExpr>(S)) {
findLambdaReferenceCaptures(LE);
return;
}
+ if (auto *CE = dyn_cast<CallExpr>(S)) {
+ findCallReferenceParameters(CE);
+ return;
+ }
+
+ if (auto *CE = dyn_cast<CXXConstructExpr>(S)) {
+ findConstructorReferenceParameters(CE);
+ return;
+ }
+
const UnaryOperator *U = dyn_cast<UnaryOperator>(S);
if (!U)
return;
@@ -522,6 +531,31 @@
Escaped.insert(VD);
}
}
+
+ void findReferenceParameter(const FunctionDecl *FD,
+ CallExpr::const_arg_range Args) {
+ for (const auto It : llvm::zip(FD->parameters(), Args)) {
+ if (!std::get<0>(It)->getType()->isReferenceType())
+ continue;
+
+ auto *DRE = dyn_cast<DeclRefExpr>(std::get<1>(It));
+ if (!DRE)
+ continue;
+
+ if (auto *VD = dyn_cast<VarDecl>(DRE->getDecl()))
+ Escaped.insert(VD);
+ }
+ }
+
+ void findCallReferenceParameters(const CallExpr *CE) {
+ if (auto *FD = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl())) {
+ findReferenceParameter(FD, CE->arguments());
+ }
+ }
+
+ void findConstructorReferenceParameters(const CXXConstructExpr *CE) {
+ findReferenceParameter(CE->getConstructor(), CE->arguments());
+ }
};
} // end anonymous namespace
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
