NoQ added a comment. Thanks! I've seen a couple false positives like this and I'm shocked that this wasn't already how things worked.
I agree with @steakhal, we should add a test case that demonstrates an actual false positive suppressed by this patch. The tests that you've added are "FIXME" tests that demonstrate regressions caused by this patch - which is great and we should totally keep them! - but we should add a comment saying that in ideal world, if this checker's analysis was interprocedural, we would have noticed that this is still a dead store. But the purpose of tests is to avoid regressions, so it's important to add a test that demonstrates the improvement as well, so that this improvement wasn't lost. If we don't have improvements tested, somebody may remove your code and say "Hey, I haven't regressed anything and I even improved behavior on some tests!". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
