lebedev.ri requested changes to this revision.
lebedev.ri added inline comments.
This revision now requires changes to proceed.
================
Comment at:
clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:41
+ llvm::StringRef(kAbseilThreadAnnotationsHeader);
+ if (actual_header.endswith(original_header)) {
+ FixItHint hint = FixItHint::CreateInsertion(Range.getBegin(), "ABSL_");
----------------
This isn't being tested. What happens if the macro comes from non-abseil header?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63929/new/
https://reviews.llvm.org/D63929
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
