gribozavr added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:43 + FixItHint hint = FixItHint::CreateInsertion(Range.getBegin(), "ABSL_"); + Check.diag(Range.getBegin(), "usage of unprefixed thread annotation") + << hint; ---------------- gribozavr wrote: > "unprefixed" is not something that the user cares about. Try wording it the > message around deprecation. Describing the fix-it in the message is also a > good idea. > > "annotations without the 'ABSL_' prefix are deprecated; use the new name > instead" Same suggestion for the check name. WDYT about "DeprecatedThreadAnnotationsCheck"? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63929/new/ https://reviews.llvm.org/D63929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
