lebedev.ri added a comment.
(Stuck reviews are bad, but blind stamping is even worse..)
================
Comment at:
clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:15-16
+
+constexpr char kAbseilThreadAnnotationsHeader[] =
+ "absl/base/internal/thread_annotations.h";
+
----------------
constexpr StringLiteral ?
shouldn't this be in anonymous namespace, or be `static`?
================
Comment at:
clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:37
+ const MacroArgs *Args) {
+ llvm::StringRef actual_header =
+ SM.getFilename(MD.getMacroInfo()->getDefinitionLoc());
----------------
This isn't correct as per coding style
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63929/new/
https://reviews.llvm.org/D63929
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
