gribozavr added a reviewer: gribozavr. gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land.
Do you have commit access? ================ Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:43 + FixItHint hint = FixItHint::CreateInsertion(Range.getBegin(), "ABSL_"); + Check.diag(Range.getBegin(), "usage of unprefixed thread annotation") + << hint; ---------------- "unprefixed" is not something that the user cares about. Try wording it the message around deprecation. Describing the fix-it in the message is also a good idea. "annotations without the 'ABSL_' prefix are deprecated; use the new name instead" Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63929/new/ https://reviews.llvm.org/D63929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
