----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/#review1275 -----------------------------------------------------------
OK, I am contributing "a small" refactor with separate controller object: http://community.kde.org/Calligra/Libs/KoAbstraction#Refactoring It should take some time though to port f-office (what I also do for you). - Jarosław On Jan. 31, 2011, 12:07 p.m., Mani Chandrasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100462/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2011, 12:07 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > This patch removes KoAbstraction class which implements > KoAbstractionContorller. > > Since we are reimplementing most of the functions in MainWindow.cpp I have > removed KoAbstraction class and moved all the signals to MainWindow > I feel the implementation should be in freoffice code instead of abstraction > library. > > Is there any possible drawbacks in this approach? > > > Diffs > ----- > > tools/CMakeLists.txt d4e6ab5 > tools/f-office/CMakeLists.txt a212bc0 > tools/f-office/MainWindow.h f7b6149 > tools/f-office/MainWindow.cpp 549b7d1 > > Diff: http://git.reviewboard.kde.org/r/100462/diff > > > Testing > ------- > > > Thanks, > > Mani > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
