On Sunday 05 September 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Fri, Sep 03, 2010 at 12:14:18AM CEST:
> > * tests/defs.in ($srcdir): Define unconditionally to
> > @abs_src...@. Remove code $srcdir normalization, which is now
> > useless.
> >
> > --- a/tests/defs.in
> > +++ b/tests/defs.in
> > @@ -21,7 +21,7 @@
> >
> > # Tom Tromey <tro...@cygnus.com>
> >
> > # Absolutely necessary variable(s).
> >
> > -srcdir=${srcdir-'@abs_srcdir@'}
> > +srcdir='@abs_srcdir@'
>
> Can you explain why this is not needed conditionally any more?
For consistency with the variable `$top_scrdir' introduced
in the PATCH 2/4, which is unconditonally defined. Also, while in my
endless tweaking an experimentation with the testsuite I've wanted to
and/or resorted to override many things, I not once needed or wished
to override $(srcdir). And the uncondional definition let us remove
# the code below for srcdir "absolutization".
> I mean, was there a reason we didn't already do that last time?
Which last time?
Regards,
Stefano
