----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105166/ -----------------------------------------------------------
(Updated June 21, 2012, 9:41 p.m.) Review request for Amarok and Sven Krohlas. Changes ------- Tests for the redundant CollectionBase class have been removed along with the trivial or "implemented for convenience" methods in TrackProvider and Collection classes The tests for isWritable and isOrganizable functions now use the data driven testing mechanism Tabs have been removed and proper indentation done Description ------- This patch implements a unit test for core/collections/Collection There are abstract classes to be tested as well, which can only be done when subclasses define the pure virtual functions. So tests for those will be done along with the subclasses. Diffs (updated) ----- tests/core/collections/CMakeLists.txt 2efd1fe tests/core/collections/TestCollection.h PRE-CREATION tests/core/collections/TestCollection.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105166/diff/ Testing ------- Test passes on my repository Thanks, Jasneet Bhatti
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
