> On June 21, 2012, 2:08 p.m., Matěj Laitl wrote: > > tests/core/collections/TestCollection.cpp, line 220 > > <http://git.reviewboard.kde.org/r/105166/diff/2/?file=70025#file70025line220> > > > > While not strictly needed in tests, it is good habit to write code > > without memory leaks. Here you would "delete collection;", because it > > doesn't delete itself unless prepareSomething() is called on it.
Oh I wanted to say: delete collection in every test (do you know about init(), initTestCase() and friends?) plus delete returned location in this test. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105166/#review14948 ----------------------------------------------------------- On June 21, 2012, 1:38 p.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105166/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 1:38 p.m.) > > > Review request for Amarok and Sven Krohlas. > > > Description > ------- > > This patch implements a unit test for core/collections/Collection > > There are abstract classes to be tested as well, which can only be done when > subclasses define the pure virtual functions. So tests for those will be done > along with the subclasses. > > > Diffs > ----- > > tests/core/collections/CMakeLists.txt 2efd1fe > tests/core/collections/TestCollection.h PRE-CREATION > tests/core/collections/TestCollection.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105166/diff/ > > > Testing > ------- > > Test passes on my repository > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
