From: Jan Beulich <[email protected]> To: "Andrew Cooper"<[email protected]> Cc: "Roger Pau Monné"<[email protected]>, "Stefano Stabellini"<[email protected]>, "Julien Grall"<[email protected]>, "Volodymyr Babchuk"<[email protected]>, "Bertrand Marquis"<[email protected]>, "Michal Orzel"<[email protected]>, "consulting @ bugseng . com"<[email protected]>, "Nicola Vetrini"<[email protected]>, "Xen-devel"<[email protected]>, "Christopher Clark"<[email protected]>, "Daniel P. Smith"<[email protected]> Date: Mon, 23 Feb 2026 04:15:55 -0500 Subject: Re: [PATCH 03/12] xen/argo: Fix MISRA violations around function parameters
> On 20.02.2026 22:46, Andrew Cooper wrote: > > For the ARM build only, Eclair reports a R8.4 violation because > > do_argo_op() > > cannot see its declaration. This means that x86 is picking > > hypercall-defs.h > > up transitively while ARM is not. Include xen/hypercall.h explicitly. > > > > Eclair also reports a R8.3 violation because of arg3 and arg4 differing in > > name with a raw_ prefix. Because hypercall-defs.h generates both > > do_argo_op() > > and compat_argo_op() from a single description, it's not possible to > > simply > > rename to raw_ in the declaration, as that would force doing the same > > rename > > in compat_argo_op(). > > > > In do_argo_op(), drop the split parameter handling, and perform the 32bit > > range check via an explicit cast. While adjusting the surrounding logic, > > drop > > unnecessary casts to void * for already pointer arguments in > > argo_printk(). > > > > No functional change. > > > > Signed-off-by: Andrew Cooper <[email protected]> > > Reviewed-by: Jan Beulich <[email protected]> > Reviewed-by: Daniel P. Smith <[email protected]>
