On 20.02.2026 22:46, Andrew Cooper wrote: > For the ARM build only, Eclair reports a R8.4 violation because do_argo_op() > cannot see its declaration. This means that x86 is picking hypercall-defs.h > up transitively while ARM is not. Include xen/hypercall.h explicitly. > > Eclair also reports a R8.3 violation because of arg3 and arg4 differing in > name with a raw_ prefix. Because hypercall-defs.h generates both do_argo_op() > and compat_argo_op() from a single description, it's not possible to simply > rename to raw_ in the declaration, as that would force doing the same rename > in compat_argo_op(). > > In do_argo_op(), drop the split parameter handling, and perform the 32bit > range check via an explicit cast. While adjusting the surrounding logic, drop > unnecessary casts to void * for already pointer arguments in argo_printk(). > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Stefano Stabellini <[email protected]> > CC: Julien Grall <[email protected]> > CC: Volodymyr Babchuk <[email protected]> > CC: Bertrand Marquis <[email protected]> > CC: Michal Orzel <[email protected]> > CC: [email protected] <[email protected]> > CC: Nicola Vetrini <[email protected]> Further Cc-ing Argo maintainer / reviewer. Jan
