On 20.02.2026 22:46, Andrew Cooper wrote: > Eclair complains that _MSC_VER is undefined (a Rule 20.9 violation). > > This could be fixed by inserting an "&& defined(_MSC_VER)" clause, but the > whole block is entirely useless (it comments out the include of stdint) and > the top of vmac.c pulls in xen/types.h specifically.
And any other user of the header (tboot.c currently). Wouldn't we be better off having vmac.h include xen/types.h instead of that useless block? > Simply delete the block. > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]> Either way: Acked-by: Jan Beulich <[email protected]> Jan
